jun7 / wyeb

a vim-like webkit2gtk web browser
GNU General Public License v3.0
105 stars 6 forks source link

support for libsoup3/webkit2gtk-4.1 #49

Closed hovercats closed 2 years ago

hovercats commented 2 years ago

So, Ive been messing some with getting webkit2gtk to work with libsoup3, as I wanted to keep libsoup up to date. This resulted in webkit no longer being 4.0, but rather 4.1. in which wyeb does not seem to be compatible with at the moment.

I changed the lines with webkit2gtk*-4.0 to 4.1. This results in the following output;

main.c: In function '_openuri': main.c:1327:17: error: unknown type name 'SoupURI' 1327 | SoupURI *suri = soup_uri_new(uri); | ^~~~~~~ ext.c: In function 'tofull': ext.c:374:9: error: unknown type name 'SoupURI' 374 | SoupURI *base = soup_uri_new(bases); | ^~~~~~~ ext.c:375:9: error: unknown type name 'SoupURI' 375 | SoupURI *full = soup_uri_new_with_base(base,uri); | ^~~~~~~ make: *** [makefile:14: wyeb] Error 1 make: *** Waiting for unfinished jobs.... ext.c: In function 'reqcb': ext.c:1827:9: error: unknown type name 'SoupURI' 1827 | SoupURI *puri = soup_uri_new(pagestr); | ^~~~~~~ ext.c:1841:17: error: unknown type name 'SoupURI' 1841 | SoupURI *ruri = soup_uri_new(reqstr); | ^~~~~~~ make: *** [makefile:22: ext.so] Error 1

Would it be of any interest in adding support for using libsoup3/webkit2gtk-4.1? Or move over to 4.1, or support for both perhaps? Any houghs on this?

jun7 commented 2 years ago

Hi. Thank you for reporting. I'm interest in adding support 4.1. don't move to 4.1 though.

hovercats commented 2 years ago

Awesome. That seems to have done the trick. Wyeb now buils fine. I havent been able to do much testing yet, but seems to work fine. Closing the issue, and should there be any other issues Ill get back to you. Cheers :+1: