search

junaidbhura / composer-wp-pro-plugins

Composer installer for Pro WordPress plugins.
https://packagist.org/packages/junaidbhura/composer-wp-pro-plugins
MIT License
92 stars 28 forks source link

Restructure #11

Closed szepeviktor closed 5 years ago

szepeviktor commented 5 years ago

@junaidbhura What do you think?

junaidbhura commented 5 years ago

Hi @szepeviktor Thanks for the pull request!

Could you please elaborate what you mean by "make it like a real composer pkg"?

szepeviktor commented 5 years ago

Could you please elaborate what you mean by "make it like a real composer pkg"?

  1. Please pick any well-known Composer package
  2. Look at where its namespace root is
  3. You find that it is in src/

That is why.

szepeviktor commented 5 years ago

src/ separates your source files from other files!

junaidbhura commented 5 years ago

Understood @szepeviktor . Let me take a look at this pull request at length, and merge it if it all looks okay.

Thanks again!

junaidbhura commented 5 years ago

@szepeviktor Unfortunately, as I'd mentioned on the other issue, I'm going to be doing a bit of a re-write of this plugin, which will conflict with the changes you've added.

As such, I'm going to have to close this pull request, sorry about that!

Thanks again for your contribution.