junaidbhura / composer-wp-pro-plugins

Composer installer for Pro WordPress plugins.
https://packagist.org/packages/junaidbhura/composer-wp-pro-plugins
MIT License
91 stars 28 forks source link

Add support for Dotenv v3, v4, and v5 #25

Closed mcaskill closed 3 years ago

mcaskill commented 3 years ago

Checklist:

Description

Adds support for Dotenv v5 while also keeping support for v4 and restoring support for v3.

This allows older projects that might be stuck on an older version of Dotenv to continue to benefit from updates to this Composer plugin.

How has this been tested?

I'm testing this on a client project that uses Advanced Custom Fields Pro, Gravity Forms, and Polylang Pro.

Types of changes

Added

Changed

junaidbhura commented 3 years ago

Thanks @mcaskill ! As always, much appreciated!

Let me take a deeper look and get back to you!

junaidbhura commented 3 years ago

Hey @mcaskill can we limit this PR to just the changes in Installer.php and composer.json?

I'm looking to do a big refactor of this plugin in the coming months, which will implement an Abstract class, etc.

mcaskill commented 3 years ago

Sorry for the delay and thanks for the feedback.

junaidbhura commented 3 years ago

Thanks @mcaskill really appreciate it as always 👍