Closed Twansparant closed 2 years ago
@Twansparant Twansparant
we've been facing same issue
composer-wp-pro-plugins
is simply not yet compatible to 2.3.0
(no release done since 7 months and composer
had released 2.3.0
this month (yday): https://github.com/composer/composer/releases
a solution would be to rollback to previous composer
version (2.1
, 2.2
seems to be ok) and wait for junaidbhura
to be compatible with 2.3.0
Yeah I just rolled back to version 2.2.10
and that just throws a notice instead of an error:
Deprecation Notice: pathinfo(): Passing null to parameter #1 ($path) of type string is deprecated in phar:///usr/local/bin/composer/src/Composer/Downloader/FileDownloader.php:457
@Twansparant Twansparant then 2.1
(works on our side)
No sorry, I meant 2.2.10
also works for me!
Came across this yesterday. Downgraded Composer to 2.2.10
and it worked for me too. I think its because of strict type checking. Will have to take a look.
More info: https://blog.packagist.com/composer-2-3/ https://github.com/composer/composer/releases/tag/2.3.0
@junaidbhura i can have a look this week if needed
meanwhile, it might worth updating (or adding a note on) README.md
(https://github.com/junaidbhura/composer-wp-pro-plugins/blob/master/README.md?plain=1#L31) until compatible with composer 2.3.0
I'm also experiencing this problem on composer 2.3.0
and initial debugging (I might be totally wrong tho) shows that the PluginEvents::PRE_FILE_DOWNLOAD
event is loaded after it loads the $package->getDistUrl()
in the composer/src/Composer/Downloader/FileDownloader.php#L437
getFileName
function, which means the distUrl
gets changed too late.
I think I found a solution, add a trailing slash to the "dist" url:
"dist": {
"type": "zip",
"url": "https://www.advancedcustomfields.com/"
},
The packages will now install like before. The downside is that this requires developers to edit their composer.json
file, instead of simply updating this package.
Hello All,
Unfortunately it looks like this happens outside of the plugin here: https://github.com/composer/composer/blob/main/src/Composer/Downloader/FileDownloader.php#L439
So as @arjendejong12 pointed out - the solution in this case will be to just add a trailing slash /
in the packages' dist URLs. I'm going to close this issue and update the README of this plugin to reflect this.
Hi there,
Since composer versions
2.3+
, I'm getting this error when runningcomposer install
with gravityforms:Any idea what's going on? Thanks!