search

junaidbhura / composer-wp-pro-plugins

Composer installer for Pro WordPress plugins.
https://packagist.org/packages/junaidbhura/composer-wp-pro-plugins
MIT License
92 stars 28 forks source link

Class Wpml does not comply with psr-4 autoloading standard #54

Closed Twansparant closed 1 year ago

Twansparant commented 1 year ago

Hi Junaid,

Really happy to see WPML support in your latest release, awesome! However when I upgrade to the latest version, I get this warning:

Class Junaidbhura\Composer\WPProPlugins\Plugins\Wpml located in ./vendor/junaidbhura/composer-wp-pro-plugins/plugins/WPML.php does not comply with psr-4 autoloading standard. Skipping.

Are you already aware of this?

mcaskill commented 1 year ago

Huh. I thought I renamed the file accordingly. Git or my non-case-sensitive OS must not have taken my file rename seriously.

mcaskill commented 1 year ago

@junaidbhura When you have a chance, can you rename the file to match the class name?

I don't think we need a pull request to resolve this mistake. Furthermore, if you want, you can add me as a maintainer to help out.

mattneal-stafflink commented 1 year ago

+1 for fixing this. No biggie, but still!

junaidbhura commented 1 year ago

Hey @Twansparant a new version 1.8.0 has been released. Can you check if that release fixes this issue?

Twansparant commented 1 year ago

Can you check if that release fixes this issue?

I don't see that warning anymore when running composer update so I guess it's fixed! Thanks!

mattneal-stafflink commented 1 year ago

Can you check if that release fixes this issue?

I don't see that warning anymore when running composer update so I guess it's fixed! Thanks!

Same :)

junaidbhura commented 1 year ago

Great! Props to @szepeviktor for the fix!