junaidbhura / fly-dynamic-image-resizer

Fly Dynamic Image Resizer plugin for WordPress
https://wordpress.org/plugins/fly-dynamic-image-resizer/
MIT License
162 stars 26 forks source link

Plugin Compatibility #17

Closed benplum closed 6 years ago

benplum commented 6 years ago

Adding filter to ensure fly images are re-generated when attachment meta data is generated (for better integration with plugins like My Eye Are Up Here).

junaidbhura commented 6 years ago

Hey @benplum thanks for the PR!

Let me investigate the original flow of how wp_generate_attachment_metadata is called, and then in the context of plugins using it, and get back to you. Cheers!

junaidbhura commented 6 years ago

Hey @benplum although this is definitely good functionality, I think it would be best to keep this plugin as light as possible, only with functionality that is essential to it.

For the moment, I think for cases like the one you mentioned, you can add the code to your theme / plugin and delete the fly image from there:

JB\FlyImages\Core::get_instance()->delete_attachment_fly_images( $attachment_id );

Sorry about that!