Feature/can handle attachment

junaidbhura / fly-dynamic-image-resizer

Fly Dynamic Image Resizer plugin for WordPress

https://wordpress.org/plugins/fly-dynamic-image-resizer/

MIT License

162 stars 26 forks source link

Feature/can handle attachment #43

Closed FarkasJanos closed 3 years ago

FarkasJanos commented 3 years ago

Checklist:

[x] I've read the Contributing page.
[x] I've created an issue and referenced it here.
[x] My code is tested.
[x] My code follows the WordPress code style.
[x] My code has proper inline documentation.

Description

Added extra check to detect we got image attachment and we can resize and save that image

How has this been tested?

Tested manually Current modifications need higher WordPress version

wp_get_attachment_image_url since 4.4.0
wp_image_editor_supports since 3.5.0

Screenshots

Types of changes

New feature (non-breaking change which adds functionality) #42

FarkasJanos commented 3 years ago

Maybe i can change the checks, to keep compatiblity with WordPress version 3.0. What do you think?

junaidbhura commented 3 years ago

Thanks for the pull request @FarkasJanos ! Let me take a deeper look at this and get back to you!

JDenne commented 3 years ago

+1 on this. Thanks @FarkasJanos for your work on this. Look forward to it being merged. We're currently having to check if it's an SVG before using fly so this will be a big help.

junaidbhura commented 3 years ago

Hi @FarkasJanos apologies for the delayed response. I had the opportunity to look at this at length today. I've created another PR for this for the following reasons:

This plugin supports WordPress 3.0 and above, and it might break backwards compatibility
Performance reasons

Do you think you could pull this branch down and test if it fixes the issue? https://github.com/junaidbhura/fly-dynamic-image-resizer/pull/45