juncongmoo / pyllama

LLaMA: Open and Efficient Foundation Language Models
GNU General Public License v3.0
2.8k stars 312 forks source link

rewrite download_community.sh #71

Closed llimllib closed 1 year ago

llimllib commented 1 year ago

This PR is a rewrite of download_commity.sh. Its primary focus is readability and compatibility with older bash versions. (see https://github.com/juncongmoo/pyllama/issues/47#issuecomment-1499265114 for why it doesn't work with bash 3, which (unfortunately) is mac's default bash version).

I tested it by doing /bin/bash download_community.sh 7B,13B /tmp/llama-models on an m1 mac, which runs the script with bash 3.2.57.

Shellcheck reports no warnings:

$ shellcheck download_community.sh

on the version of the script in main, it shows many warnings.

mldevorg commented 1 year ago

This branch has conflicts that must be resolved.... Can you please resolve the conflicts? @llimllib Thank you.

llimllib commented 1 year ago

👍 fixed

blah-mad commented 1 year ago

please merge, it's 4 am here and i have been looking at this PR dead straight for the last 20 mins.

P.s. tons of thank you and a happy easter! ⭐ 🥚