jundatan / pe

1 stars 0 forks source link

Wrong error thrown when using a date that is invalid #4

Open jundatan opened 1 year ago

jundatan commented 1 year ago

Tried to use date that does not exist but was thrown with an error talking about time format.

Steps to reproduce: Enter the command newevent n/2362636463464636342 r/23555555555555555555555 a/Johnś house ds/31-02-2024 19:00 de/31-02-2023 19:00

Expected: Date is invalid error.

Actual: Time should be a valid time of the format dd-MM-yyyy hh:mm

image.png

nus-se-bot commented 1 year ago

Team's Response

User tried to input an invalid date and the error message did address that input values and formatting should be valid.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The team seems to not understand the problem. The error is only talking about time and not date. User will be thrown off thinking that their time is invalid but it is actually the date that is invalid. It is acceptable if they talk about Time and Date even though it makes it generic. But they only show that the Time which confuses the user.