search

jundatan / pe

1 stars 0 forks source link

End date can come before start date #5

Open jundatan opened 1 year ago

jundatan commented 1 year ago

End date of the event can come before the start date.

Steps to reproduce: Enter the command newevent n/2362636463464636342 r/23555555555555555555555 a/Johnś house ds/20-02-2024 19:00 de/20-02-2023 19:00

Expected: End date should not come before start date error.

Actual: New event added: Tommy wedding; Rate: 23555555555555555000000.00; Address: Johnś house; Timing: 20-02-2024 19:00 to 20-02-2023 19:00; Mark: [ ]

image.png

I will put this bug report serverity as medium but i feel it could be leaning to high too since it will cause a lot of issue with the event setting.

nus-se-script commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

End Date of an event allowed to be before the Start Date

Description

Missing validation check for whether dates are chronologically valid.

Steps to reproduce

  1. Enter the command newevent n/DJ at wedding r/100 a/311, Clementi Ave 2, #02-25 ds/11-03-2023 11:00 de/11-02-2023 17:00 t/friends t/dj. The start month in this case is March, and the end month is February.

  2. The event is successfully added.

image.png

[original: nus-cs2103-AY2223S2/pe-interim#3220] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

It is already stated in the DG where it will be planned for future enhancements.

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** This is a functionality bug and not a feature flaw. Planned enhancements are for feature flaw related. Having an end date before start date will also break the command for remind. Hence, this should not be placed under planned enhancements which only allows for feature flaws. I feel that it should only be acceptable to put it under planned enhancement to change the message if there is at least an error thrown (maybe a generic error message) when putting the start date after the end date. Hence, planned enhancement is for feature flaws and not functionality bug that will break their application. Above is the same reasoning as my bug report #9 for `edit` command. However, this is for `newevent` command.
## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** This severity should be medium as there are many cases where people accidentally mistyped a certain digit causing the end date to be before the start date. One good example is people using paylah nowadays and accidentally mistype the amount from 5 dollars to 500 dollars. It may sound exaggerating but i can assure that every one of us has mistyped or misspelled something when entering words or numbers. Hence, i disagree that this should be low as this is also one of the most important feature in an event. Above is the same reasoning as my bug report #9 for `edit` command. However, this is for `newevent` command.