search

jundongl / scikit-feature

open-source feature selection repository in python
GNU General Public License v2.0
1.51k stars 447 forks source link

Fisher Score (Possible Bug?) #71

Closed crixus5678 closed 2 years ago

crixus5678 commented 2 years ago

In the fisher score calculation (https://github.com/jundongl/scikit-feature/blob/48cffad4e88ff4b9d2f1c7baffb314d1b3303792/skfeature/function/similarity_based/fisher_score.py) , it was mentioned L = D - W (line 10) but in the code, L was simply defined as L = W (line 38)

I'm not sure is this a bug or if I miss out anything? Anyone came across the same issue?

crixus5678 commented 2 years ago

Verified that such implementation can obtained the same results as what is indicated on paper.