search

juneau-project / juneau

A Jupyter notebook extension to centralize and manage data
https://juneau.readthedocs.io/
Apache License 2.0
14 stars 2 forks source link

Suggestion: Incorporate Pycharm to the dev's workflow #8

Closed nachonavarro closed 4 years ago

nachonavarro commented 4 years ago

I think that establishing the use of an IDE for Juneau developers would be have a tremendous benefit. There are a lot of code warnings that pycharm can help to solve to keep code clean and efficient. Consider this code in search_withprov_opt.py:

Screen Shot 2020-07-17 at 12 05 35

Out of the box pycharm is telling us that:

  1. On lines 843 and 845 we are assigning a variable that is never used again (so we can remove all of that)
  2. On line 847 we are calling a function __remove_dup2 that doesn't even exist, so in fact this code will crash live.
  3. There is code duplication on line 862 from another file.

I think as a general rule of thumb we should aim to have no code warnings in all of Juneau, which translates to having no yellow lines on the right side scroll bar on the image.

What do you guys think?