search

junedomingo / movieapp

Discover Movies and TV shows - React Native
MIT License
1.82k stars 473 forks source link

Fix for network errors #23

Closed emretekince closed 6 years ago

emretekince commented 6 years ago

Some users cant read .env so it causes network errors. It is better to define configs directly at here.

21

junedomingo commented 6 years ago

Hi @emretekince , thanks for submitting a PR, though I don't think it's necessary

First, the PR is incomplete, I mean you didn't add instruction somewhere in readme that they need to change the values in api.js.

Second, the Installation process in Readme is so clear that they need to add .env file or else it'll cause an error.