junedomingo / react-native-rename

Rename react-native app with just one command
MIT License
2.63k stars 261 forks source link

Support new architecture(fabric) #163

Closed leegeunhyeok closed 1 year ago

leegeunhyeok commented 2 years ago

Description

Now update jni native code contents.

Android app crash on start up when rename and run with new architecture, because wrong path in new architecture's native code(jni) after run react-native-rename. (it's dependent on java package path)

This PR will resolve #162 issue.

Changes

How to test

Rename app and build with new architecture, should app starts successfully.

# create react native project
npx react-native init test

# set newArchEnabled to true on gradle.properties

# clone
git@github.com:leegeunhyeok/react-native-rename.git && cd react-native-rename
git checkout feat/support-newarchitecture
npm install && npm run build
npm install -g . 

# move to test project's root directory
react-native-rename "Rename" -b com.test.rename

# build and run
npm run android
# or 
yarn android

Screenshots

(rename)

Screen Shot 2022-11-09 at 6 11 53 PM

(changes)

Screen Shot 2022-11-09 at 6 13 30 PM Screen Shot 2022-11-09 at 6 13 15 PM

Contexts

refs #162

junedomingo commented 1 year ago

Thanks @leegeunhyeok , just release v3. closing this now