Fixed some bugs found

[ROG3R-DEV]

Resume

First I would like to thank @junedomingo for maintaining this repository!

I've been using react-native-rename for a little over a year, recently upgraded from v2.9.0 to v3.2.7. I noticed that there was a refactoring that greatly improved the organization and understanding of the code, but I noticed some problems when thoroughly testing this new version:

The command used to test was:

react-native-rename "Travel App" -b com.test.travelapp --skipGitStatusCheck

the original project name is "Original App" ( com.test.original )

Bugs ( Fixed )

Ios

• Description: Name is not changing

• path: /TravelApp/iOS/AppDelegate.m

• result:

• expected:

moduleName:@"TravelApp"

• Description: Entitlements name is not changing

• path: /TravelApp/iOS/TravelApp.xcodeproj/project.pbxproj

• result:

• expected:

TravelAppRelease.entitlements

• Description: CODE_SIGN_ENTITLEMENTS is not changing

• path: /TravelApp/iOS/TravelApp.xcodeproj/project.pbxproj

• result:

• expected:

TravelApp/TravelAppRelease.entitlements;

• Description: "name" Should not contain space

• path: /TravelApp/app.json

• result:

• expected:

{
  "name": "TravelApp",
  "displayName": "Travel App"
}

Android

• Description: Main Component Name should not contain space

• path: /TravelApp/android/app/src/main/java/com/test/travelapp/MainActivity.java

• result:

• expected:

return "TravelApp";

• Description: Rootproject should not contain space

• path: /TravelApp/android/settings.gradle

• result:

• expected:

rootProject.name = 'TravelApp'

Final considerations

Some of these bugs were preventing android application build and errors in xcode on ios.

After the corrections I ran several exhaustive tests and now everything looks good.

I hope my contribution helps those who are experiencing problems. See you later 🎉

[junedomingo]

Thanks for this @ROG3R-DEV , for the *Release.entitlements included in v3.2.10 but for the rest, I'm not so sure. I',m using rn 0.70 for testing and even with spaces on android related changes here it still works fine

[ROG3R-DEV]

Thanks for this @ROG3R-DEV , for the *Release.entitlements included in v3.2.10 but for the rest, I'm not so sure. I',m using rn 0.70 for testing and even with spaces on android related changes here it still works fine

@junedomingo Sorry for the late reply, I had to be away for a few days.

The changes make the module compatible with any version of react native.

I had problems using it in projects prior to 0.70. To be more specific it failed on projects in the versions below:

react native 0.66.4 react-native: 0.64.8 react-native: 0.62