search

junegunn / fzf-git.sh

bash and zsh key bindings for Git objects, powered by fzf
612 stars 53 forks source link

Add shellcheck github action #2

Closed matthiasbeyer closed 2 years ago

matthiasbeyer commented 2 years ago

Not sure whether you care for this, but asking does not hurt, does it?

So this adds a shellcheck github action. I guess you still would need to configure the repository accordingly though.

matthiasbeyer commented 2 years ago

This PR would need to clean up the warnings and errors shellcheck reports, of course: https://github.com/matthiasbeyer/fzf-git.sh/runs/7833865116

Let me know if you're interested and I'll continue :smile:

junegunn commented 2 years ago

Thanks for the suggestion, but I don't think shellcheck will help much here. Most of the warnings I see are red herrings and they can't be fixed because the file contains both bash and zsh constructs.