search

junegunn / fzf-git.sh

bash and zsh key bindings for Git objects, powered by fzf
612 stars 53 forks source link

[feature request] fish support #22

Closed tigerinus closed 1 year ago

tigerinus commented 1 year ago

Would be awesome to support fish. Thanks!

junegunn commented 1 year ago

Thanks for the suggestion, but I'm not a fish user and I'm not well-versed in its non-standard scripting facility. So, no, I'm not interested in supporting it.

j-lakeman commented 5 months ago

Would you accept a PR if someone ported it to fish?

junegunn commented 5 months ago

It depends on the complexity of the code. Once I merge the code, I take on the burden of maintaining the code from then on.

j-lakeman commented 5 months ago

AFAIK fish has far better readability than Shell or Bash, similar to Python. Only it lacks few "advanced" features Bash has got e.g. dictionaries. In its documentation there is even a dedicated section fish for Bash users. I could imagine porting your code to fish.

junegunn commented 5 months ago

I could imagine porting your code to fish.

Are you interested in doing that?

j-lakeman commented 5 months ago

I'd give it a try at least. Can't promise anything though!