search

junegunn / fzf-git.sh

bash and zsh key bindings for Git objects, powered by fzf
612 stars 53 forks source link

Keybings macOS #24

Closed CpnNixel closed 1 year ago

CpnNixel commented 1 year ago

It appears no keybinds work in my macOS Ventura 13.3, or maybe I'm doing something wrong.

Is it supposed to work on macOS or separate PR is needed?

RyanzpLee commented 1 year ago

I'm also having the same issue. Both in Kitty, and the standard mac terminal it's not working. For me I think it potentially stopped working after the recent omz update https://github.com/ohmyzsh/ohmyzsh/blob/master/tools/changelog.sh but I'm unsure what changes could have broken it

❯ omz version master (b4f9698) ❯ MacOS Version 13.2.1 (22D68) ❯ fzf --version 0.38.0 (brew) ❯ Kitty version Version 0.27.1 (0.27.1)

When I check what keys are binded this is what shows up

❯ bindkey -p "^G"
"^G^B" fzf-git-branches-widget
"^G^E" fzf-git-each_ref-widget
"^G^F" fzf-git-files-widget
"^G^G" fzf-gg-widget
"^G^H" fzf-git-hashes-widget
"^G^R" fzf-git-remotes-widget
"^G^S" fzf-git-stashes-widget
"^G^T" fzf-git-tags-widget
"^Gb" fzf-git-branches-widget
"^Ge" fzf-git-each_ref-widget
"^Gf" fzf-git-files-widget
"^Gh" fzf-git-hashes-widget
"^Gr" fzf-git-remotes-widget
"^Gs" fzf-git-stashes-widget
"^Gt" fzf-git-tags-widget

Here's a link to my .zshrc Link to my tmux conf

If I run the zsh widget command manually it works. But when I try to use the keybinding e.g. ^G^B it does not work.

image

However, after I press enter or exit the widget I get an error:

image
RyanzpLee commented 1 year ago

Looks like the issue for me was having export KEYTIMEOUT=1 in my .zshrc. Once I commented it out, the keybindings were working again

1Mark commented 1 year ago

Looks like the issue for me was having export KEYTIMEOUT=1 in my .zshrc. Once I commented it out, the keybindings were working again

Can confirm 

unset KEYTIMEOUT
source fzf-git.sh

fixed it for me using oh-my-zsh on macOS Ventura (13.3)

breskeby commented 1 year ago

I still see that issue even with unset KEYTIMEOUT

breskeby commented 1 year ago

never mind. issues disappeared once I was within a git repo 🤦