junegunn / fzf-git.sh

bash and zsh key bindings for Git objects, powered by fzf
612 stars 53 forks source link

fix: add missing binding for shell-expand-line #41

Closed Jobin-Nelson closed 5 months ago

Jobin-Nelson commented 5 months ago

Fixes issue #39

shell-expand-line is unbound in bash vi mode. We have to bind it manually, unlike in emacs mode which is the default

junegunn commented 5 months ago

Thanks!

junegunn commented 5 months ago

Hmm, I'm going to revert this because users can mistakenly type ESCCTRL-E and trigger shell-expand-line.

In the main fzf repo, we used to bind shell-expand-line to a key sequence that is not easy to type by accident.

https://github.com/junegunn/fzf/commit/b22fd6de6db852f9cbecc5f1e173f701876fccdc

But we no longer use even that. Let me see what I can do.

https://github.com/junegunn/fzf/commit/9c293bb82b6be333c857d288d10aab730220a0e7

junegunn commented 5 months ago

See 23a74efafac72b0a131a9f897a5da2fc9bbc04ee