Stop :Rg command - Githubissues

junegunn / fzf.vim

fzf :heart: vim

MIT License

9.66k stars 585 forks source link

Stop :Rg command #1124

Open inaki6martinez opened 4 years ago

inaki6martinez commented 4 years ago

[X] I have fzf 0.22.0 or above
[X] I have read through https://github.com/junegunn/fzf.vim/blob/master/README.md
[X] I have read through https://github.com/junegunn/fzf/blob/master/README-VIM.md
[x] I have read through the manual page of fzf (man fzf)
[X] I have searched through the existing issues

Hello,

I have seen that if I call ":Rg search_pattern" and I press Ctrl+C or ESC to exit from the search the rg process is not finishing and it's consumming cpu and I have to kill it. If I execute only the :Rg the process finishes properly with Ctrl+C or ESC.

Also, if I open one of the results the process continues in background.

Which is the proper way to exit from the :Rg command? I have reproduced it with the minimal configuration.

junegunn commented 4 years ago

I don't have the problem. Maybe upgrade ripgrep?

half0wl commented 3 years ago

Running into the same issue here on the latest version of everything. The process doesn't seem to be killed after ESC-ing from :Rg.

OS: macOS Big Sur 11.0.1 (20B29)

$ fzf --version
0.24.4 (brew)

$ rg --version
ripgrep 12.1.1
-SIMD -AVX (compiled)
+SIMD +AVX (runtime)

$ nvim --version
NVIM v0.4.4
Build type: Release
LuaJIT 2.0.5

:command Rg output:

    Name        Args       Address   Complete  Definition
!   Rg          *                                  call fzf#vim#grep("rg --column --line-number --no-heading --color=always --smart-case -- ".shellescape(<q-args>), 1, s:p(), <bang>0)

Activity Monitor

(^ couldn't take a proper screenshot because my OS froze)

half0wl commented 3 years ago

Update on https://github.com/junegunn/fzf.vim/issues/1124#issuecomment-743109212:

My issue had to do with large files that wasn't gitignore'd in the directory; I had ~100gb of csvs that rg would repeatedly choke on. I no longer have the issue after removing the large files. I was expecting the process to be killed right after ESC-ing, but it looks like it has to "finish" the index/search (?).