junegunn / fzf.vim

fzf :heart: vim
MIT License
9.59k stars 582 forks source link

[[B]Commits] Use --color=always with delta as well #1362

Closed liskin closed 2 years ago

liskin commented 2 years ago

With some delta configurations (e.g. color-only = true, diff-highlight = true), delta doesn't add its own coloring and keeps that from git diff, and thus we need to turn that on.

Additionally, delta doesn't do its own detection of moved lines and relies on git diff's colorMoved, which also needs enabling of colors.

junegunn commented 2 years ago

Thanks. Can you post screenshots before and after the patch where this makes difference?

liskin commented 2 years ago

Sure.

Without patch: 2022-01-30-222122_1915x1044_scrot

With patch: 2022-01-30-221956_1915x1044_scrot

My git/delta config is here if you need to dig deeper :-)

junegunn commented 2 years ago

Merged, thanks.