search

junegunn / fzf.vim

fzf :heart: vim
MIT License
9.52k stars 582 forks source link

Update preview.sh to use bat's ability to jump to line range #1467

Closed dberlin closed 1 year ago

dberlin commented 1 year ago

When using bat, preview.sh will often end up trying to highlight lines that are off screen.

These days (since version 0.8, and it's on version 0.23, so a while), bat has the ability to specify a line range in the file to display.

We use it, plus the terminal height, to ensure the highlighted center line always visible.

We could use stty instead of tput to get terminal size, but everything i tried this on had tput available.

(Unfortunately, $LINES is only available in bash interactive shells)

Bat doesn't care if line-range specifies a range larger than the file, so TOPRANGE > number of lines in file is fine.

junegunn commented 1 year ago

We used to use line-range, but it was removed in https://github.com/junegunn/fzf.vim/commit/4145f53f3d343c389ff974b1f1a68eeb39fba18b in favor or the new preview window offset expression which allows upward scroll.

cat /usr/share/dict/words | nl | fzf --preview 'cat /usr/share/dict/words' --preview-window '+{1}'