junegunn / fzf.vim

fzf :heart: vim
MIT License
9.51k stars 581 forks source link

"Tab drop" no longer works as fzf action for jumping to existing tab #1508

Closed lukelbd closed 9 months ago

lukelbd commented 9 months ago

Check all that apply [x]:

Before submitting

Issue description

Thanks for maintaining this awesome plugin.

Previously I used the following configuration to have :Tags, :Ag, and :Rg switch to existing tabs:

let g:fzf_action = {
  \ 'ctrl-m': 'tab drop', 'ctrl-t': 'tab drop',
  \ 'ctrl-i': 'silent!', 'ctrl-x': 'split', 'ctrl-v': 'vsplit'
  \ }  " have file search, grep open to existing window if possible

However your commit that added support for multiple selection also meant that this no longer works (832a090). The new s:open() effectively triggers an empty :tab drop command which always opens a new tab. Is there any way you could add back support for :tab drop without dropping support for multiple selections?

junegunn commented 9 months ago

Have you tested the latest revision which contains https://github.com/junegunn/fzf.vim/commit/fe362d413a0286b1474c1d235c6eb1d0cd6ae8a4?

lukelbd commented 9 months ago

Sorry my mistake -- that fixes it! Thanks for the quick response