Bash completions conflicts with globstar setting

[barlik]

• Category
  • [ ] fzf binary
  • [ ] fzf-tmux script
  • [ ] Key bindings
  • [x] Completion
  • [ ] Vim
  • [ ] Neovim
  • [ ] Etc.
• OS
  • [x] Linux
  • [ ] Mac OS X
  • [ ] Windows
  • [ ] Windows Subsystem for Linux
  • [ ] Etc.
• Shell
  • [x] bash
  • [ ] zsh
  • [ ] fish

Running with bash, when you type:

$ source /usr/share/fzf/shell/completion.bash

$ shopt -u globstar # this allows you to use ** for recursive files/directory expansion 

$ ssh ** <tab>

it correctly uses fzf to show you a list of hosts where you can connect to.

The problem arises when you cancel the search with Ctrl-C. Then bash will try to evaluate ** as a globstar pattern and will traverse the whole tree under your current working directory. If you run it from $HOME it blocks the whole shell for a couple of minutes (depends on your disk usage).

In my opinion, the correct behavior should be not trying to do any more completion after you cancel the fzf. That's the behavior in zsh and fish.

[barlik]

Proposed solution: https://github.com/junegunn/fzf/pull/1128

[junegunn]

You can set FZF_COMPLETION_TRIGGER differently so that it does not conflict with globstar.

FZF_COMPLETION_TRIGGER=?

ssh ?<tab>

[barlik]

This will work, but I would still like to keep the default ** though.

Problem is discussed at https://github.com/junegunn/fzf/pull/1128