X-Server not able to start due to fzf update

[Nudin]

• Category
  • [ ] fzf binary
  • [ ] fzf-tmux script
  • [ ] Key bindings
  • [x] Completion
  • [ ] Vim
  • [ ] Neovim
  • [ ] Etc.
• OS
  • [x] Linux
  • [ ] Mac OS X
  • [ ] Windows
  • [ ] Windows Subsystem for Linux
  • [ ] Etc.
• Shell
  • [x] bash
  • [ ] zsh
  • [ ] fish

After I upgraded fzf from 0.17.5 -> 0.18.0 on Arch-Linux I couldn't login with the X-Server. The session is stopped imediatly after start. I still can login on terminal. After some test I found it's origin it the line

source /usr/share/fzf/completion.bash

in my .bashrc. Cmmenting it out disables the issue.

[Nudin]

I debugged this a bit: Turns out this commit causes the error: be0f79746ad1282f88460ae5314d08800cd23d74

I don't understand why, but the if-condition causes the X-Server or window manager to fail to start. Adding a single : to the file in front of the if (line 11/12) fixes the issue: https://github.com/junegunn/fzf/compare/master...Nudin:patch-1

Does anyone have any idea?