Incorrect shebang in documentation

junegunn / fzf

:cherry_blossom: A command-line fuzzy finder

https://junegunn.github.io/fzf/

MIT License

65.34k stars 2.4k forks source link

Incorrect shebang in documentation #2049

Closed Keating950 closed 4 years ago

Keating950 commented 4 years ago

[ ] I have read through the manual page (man fzf)
[ ] I have the latest version of fzf
[X] I have searched through the existing issues

The example script found in the wiki under "fzf as dmenu replacement' uses the shebang #!/usr/bin/env sh. However, it also uses disown, which is undefined in POSIX sh. A #!/usr/bin/env bash would be more portable/compatible. (I noticed because I replaced the default /bin/sh symlink to bash with one pointing to the stricter dash shell.)

junegunn commented 4 years ago

Thanks for the heads up. The page is maintained by the community and I don't review or test the code people add to it. Write permission to the page is open to everyone, so feel free to edit the code if you think it's incorrect.