junegunn / fzf

:cherry_blossom: A command-line fuzzy finder
https://junegunn.github.io/fzf/
MIT License
64.3k stars 2.38k forks source link

last good fzf for fzf.vim on Windows 10 #3790

Closed harriott closed 4 months ago

harriott commented 4 months ago

Checklist

Output of fzf --version

0.52.0 (bcda25a)

OS

Shell

Problem / Steps to reproduce

  1. fzf.exe v0.52.0
    1. Good: PS> winget add junegunn.fzf makes possible PS> ~\AppData\Local\Microsoft\WinGet\Links\fzf.exe --version, and PSFzf works beautifully, thanks.
    2. Bad: fzf.vim popups are all broken, unusable.
  2. fzf.exe v0.46.1
    1. Good: this, $Env:LOCALAPPDATA\Microsoft\WindowsApps\fzf.exe, gets everything working perfectly.
  3. fzf repository location
    1. Bad: the advice in the fzf/README-VIM.md to add the location of my fzf clone into runtimepath has never worked for me.
    2. Good: this, plugin\fzf, works perfectly.
  4. fzf 4e9e842 (current commit)
    1. Good: fzf.vim functions that access Vim info work fine.
    2. Bad: fzf.vim functions that access the shell briefly flash an empty window and nothing more.
  5. fzf 24ff66d (last week)
    1. Good: this is the last fzf commit for which fzf.vim functions perfectly for me on Windows 10.

Background: I've been happily using fzf with fzf.vim on my Arch linux and Windows 10 boxes for years, with many thanks to the developers.

junegunn commented 4 months ago

Please test if the new 0.52.1 improves the situation.

harriott commented 4 months ago
  1. fzf d91dd75 (current commit) works, thanks
  2. fzf.exe v0.52.1
    • Good: PSFzf works as usual
    • Bad: fzf.vim (again from winget)
      • useful left-side numbers and lower three lines (:: Press ...) ain't there
      • :Files works, but without my incremental input visible (no lower three lines)
      • :History variants show the popup but it goes blank on first keypress
junegunn commented 4 months ago
  • :Files works, but without my incremental input visible (no lower three lines)

Hmm, I can't reproduce the problem.

So how did you install fzf and fzf.vim? Are you running terminal vim from PowerShell? I'm testing it this minimal 4-line _vimrc:

call plug#begin()
Plug 'junegunn/fzf', { 'do': { -> fzf#install() } }
Plug 'junegunn/fzf.vim'
call plug#end()
image image
harriott commented 4 months ago

I've discovered that it's some kind of conflict with vim-airline! I really should've done more tests before bothering you. In a stripped down minimal _vimrc that just pulls in fzf, fzf.vim, and vim-airline I find the calls to fzf begin to be unstable. It was difficult to diagnose as there seemed to be some sort of memory in each PowerShell instance of previous calls such that it appeared stable but then when I relaunched PowerShell the calls to fzf failed again. (Equally if I removed vim-airline the calls wouldn't work again until I'd relaunched PowerShell.) So, only for win64, I've switched away from vim-airline and all is now working as it should with the latest fzf and fzf.vim.