search

junegunn / fzf

:cherry_blossom: A command-line fuzzy finder
https://junegunn.github.io/fzf/
MIT License
61.96k stars 2.34k forks source link

simplify cygwin handling in Git Bash #3804

Closed Konfekt closed 1 month ago

Konfekt commented 1 month ago

Just wondering, if the somewhat involved code in

https://github.com/junegunn/fzf/blob/01e7668915c4e3cf8c9eeca283d41beac924fe1f/plugin/fzf.vim#L711

to handle fzf in Cygwin or rather Git Bash nowadays can be simplified, for example by Git Bash including /usr/bin/start calling cmd //c. This was mainly added in the somewhat lengthy PR https://github.com/junegunn/fzf/pull/933 so maybe @janlazo has clearer ideas why all these measures have to be taken. In any event, I am happy that Fzf is working Git Bash at all, that's quite a feat; just wondering if developer's pain could be eased dealing with all the conversion issues.

Konfekt commented 1 month ago

This code has indeed been completely reworked, simplified and cleaned up as documented in https://github.com/junegunn/fzf/issues/3809 Fzf has become first-class citizen on Microsoft Windows.