make fzf work in standard Git Bash Term

junegunn / fzf

:cherry_blossom: A command-line fuzzy finder

https://junegunn.github.io/fzf/

MIT License

64.3k stars 2.38k forks source link

make fzf work in standard Git Bash Term #3806

Closed Konfekt closed 4 months ago

Konfekt commented 4 months ago

Script provided by @knutze

Addresses https://github.com/junegunn/fzf/issues/2798

junegunn commented 4 months ago

The approach looks quite similar to what we've been doing in fzf-tmux, and the script was recently rewritten in native Go code. I'll see if we can do the same for this. If that's possible,

it will work without extra configuration
it will work not just on bash, but also on other shells

junegunn commented 4 months ago

Can you test 573df524fed1c493ce7d8ea893f06ab90f2ca18a? It seems to work for me fine. Because it's using named pipes, it doesn't block even when the source command takes a while to complete.

./fzf
ls | ./fzf
(sleep 5; ls) | ./fzf

Attaching the binary built from the source.

fzf.exe.zip

Konfekt commented 4 months ago

I can confirm that this release works fine in Git Bash Term under Windows 10 without the bash script work around. (It works also fine with the Bash work around. Removing the new exe, the pipe is broken again.)

junegunn commented 4 months ago

Cool, I'll close this then and include the patch in the next release.