Open ykhan21 opened 3 months ago
There are two renderer implementations for Windows.
--height
and used only when --height
option is given.So with 0684a20ea3da6100cf43c919d1fcfda3644eb8c1, mouse works properly when --height
is used on mintty, but not in fullscreen mode. We can fix this by always using LightRenderer.
diff --git a/src/terminal.go b/src/terminal.go
index 128da4e..7307c17 100644
--- a/src/terminal.go
+++ b/src/terminal.go
@@ -711,7 +711,7 @@ func NewTerminal(opts *Options, eventBox *util.EventBox, executor *util.Executor
}
}
if fullscreen {
- if tui.HasFullscreenRenderer() {
+ if !tui.IsLightRendererSupported() {
renderer = tui.NewFullscreenRenderer(opts.Theme, opts.Black, opts.Mouse)
} else {
renderer, err = tui.NewLightRenderer(ttyin, opts.Theme, opts.Black, opts.Mouse, opts.Tabstop, opts.ClearOnExit,
It's a simple change, and I can confirm that it fixes the mouse problem. However, I'm not sure if there are any unwanted side effects. I could use some help testing the binary.
Checklist
man fzf
)Output of
fzf --version
0.53.0 (c4a9ccd)
OS
Shell
Problem / Steps to reproduce
scoop install git fzf
ls | fzf
Also, on Wezterm with bash, clicking does not seem to work at all, while on Wezterm with cmd, clicking works.