junegunn / goyo.vim

:tulip: Distraction-free writing in Vim
MIT License
4.5k stars 115 forks source link

fullscreen #23

Closed ghost closed 10 years ago

ghost commented 10 years ago

The set fullscreen option seems proprietary to MacVim. There is the FullScreen command of the plugin vim-shell, which seems to be OS independent.

It works just fine when toggling it s:goyo_before(), but messes slightly up when disabling it again in s:goyo_after(). The momentary workaround is two invoke it three times instead, which usually fixes the window setup.

In all these new issues raised, I'm just scrupulously mentioning one by one what struck me when trying your wonderful plugin. It might be of help to others.

junegunn commented 10 years ago

I really appreciate your thorough report.

I've never used vim-shell before, so I can't be sure. But it sounds like an issue of that plugin, not Goyo's. Could you give me the URL of the plugin? I might try it out when I have time.

ghost commented 10 years ago

It's

https://github.com/xolox/vim-shell

and appears to be the most recent among the full screen plug-ins. The reported behavior occurred on Windows 7 64bit and gvim 7.4.

Am vendredi 28 mars 2014 02:32:39 schrieb Junegunn Choi:

I really appreciate your thorough report.

I've never used vim-shell before, so I can't be sure. But it sounds like an issue of that plugin, not Goyo's. Could you give me the URL of the plugin? I might try it out when I have time.

— Reply to this email directly or view it on GitHub https://github.com/junegunn/goyo.vim/issues/23#issuecomment-38880865.

junegunn commented 10 years ago

With Windows 7, the latest version of the plugin and gvim, I don't seem to have any problem. These are the callback functions used for testing.

function! g:goyo_before()
  Fullscreen
endfunction

function! g:goyo_after()
  Fullscreen
endfunction

let g:goyo_callbacks = [function('g:goyo_before'), function('g:goyo_after')]

What exactly is the problem you're experiencing? Do you see any error message? A screenshot would be helpful, although I can't be sure if I would be able to help you since I can't reproduce the problem in my environment.

ghost commented 10 years ago

Hello,

Strangely, I cannot reproduce it today. It works impeccably. I close this for now and will come back to it at times.