junegunn / goyo.vim

:tulip: Distraction-free writing in Vim
MIT License
4.52k stars 117 forks source link

SignColumn color not restored when leaving Goyo #51

Closed alexlafroscia closed 9 years ago

alexlafroscia commented 9 years ago

I noticed that the SignColumn's background is set wrong when leaving Goyo.

Before entering Goyo:

screen shot 2015-01-21 at 6 57 52 pm

After leaving Goyo

screen shot 2015-01-21 at 6 58 14 pm

I was able to help a little bit by re-setting the SignColumn color upon leaving Goyo, but it only affected rows where the gutter wasn't being used; any rows that actually were making use of the gutter (for Git status, for example) remained the wrong color.

junegunn commented 9 years ago

I haven't run into this problem. Could you provide me with a minimal vimrc that can reproduce the problem? I mean without any other irrelevant plugins or settings.

wookayin commented 4 years ago

I ran into a similar issue. (It's after 5 years!) The highlight values of SignColumn, GitGutterAdd, etc. are all lost after leaving Goyo. Shouldn't Goyo restore existing highlights rather than simply discarding them away?

Steps to reproduce:

❯❯❯ nvim -u <(cat <<EOF
set rtp+=~/.vim/plugged/goyo.vim/
set rtp+=~/.vim/plugged/vim-gitgutter/
source ~/.vim/plugged/goyo.vim/plugin/goyo.vim
source ~/.vim/plugged/vim-gitgutter/plugin/gitgutter.vim
set termguicolors
hi SignColumn guibg=red
EOF
)

Open any file inside a git repository:

and then SignColumn is lost.