search

junegunn / vim-github-dashboard

:octocat: Browse GitHub events in Vim
484 stars 23 forks source link

Trim leading/trailing newlines from activity entries #26

Closed jonsyu1 closed 8 years ago

jonsyu1 commented 8 years ago

We use Reviewable, which creates entries with leading newlines:

  3) 💬  [jonsyu1] commented on issue [****/deployd#2550] (1 day ago)

           *[rest/api/nodestructs.go, line 38
           \[r2\]](https://reviewable.io:443/reviews/****/deployd/2550#-KJwV8TfyFybYUrXVC_0-r2-38:-KK0DUNQTz-0j5DZ2xsA:433049319)
           ([raw
           file](https://github.com/****/deployd/blob/9c37a24bae86aab56b80e7b3b45235bb7b3a6dd3/rest/api/nodestructs.go#L38)):*
           <details><summary><i>Previously, jonsyu1 wrote…</i></summary>
           > Fair point: the agent shouldn't need to reference the parent, and
           the client should know which service or daemon they're modifying
           instead of following the node's parent pointer.
           > 
           > Note that we do have the node type in `UserNodeRevision.Type`. 
           </details>
           https://github.com/****/deployd/pull/2556
           ---
           *Comments from
           [Reviewable](https://reviewable.io:443/reviews/****/deployd/2550)*
           <!-- Sent from Reviewable.io -->
junegunn commented 8 years ago

Updated the code to remove leading newlines. I also changed the formatting of the comment, so you'll notice some empty lines in between (that were incorrectly removed before).