search

jung-kim / atom-ungit

Atom plugin for Ungit project
MIT License
75 stars 12 forks source link

Close Ungit Tab Only If In Focus #11

Closed ibnesayeed closed 10 years ago

ibnesayeed commented 10 years ago

I was wandering, should we implement the workflow in a way that hitting the toggle key combination create the tab if not already, invokes Ungit process if not running, brings Ungit tab in focus if not in focus. But it kills the process and closes the tab only when Ungit tab is active.

In my workflow, I keep several files open at once. If I bring Ungit up, then without closing it start working on other files and want to have a look at Ungit tab again, hot-key will actually kill the tab first which is not desired.

I was also thinking, since it is a very special tab, should we choose to open the tab as the very first or last one, instead of next to the currently active tab? Or should we have a setting to allow users to chose this behavior?

jung-kim commented 10 years ago

https://github.com/codingtwinky/atom-ungit/commit/3497a33ba2d1ff09de4629dfdcbce30eb502c096 will place newly opened ungit page to be at the left most pane. If line 125 of new version of atom.io get published as it is and we upgrade atom.io.

But if you want to implement more immediate solution it's all yours.

Hooray for lazy and optimistic programming!!!!

ibnesayeed commented 10 years ago

This ticket can be closed now as the commits have already taken care of the main feature. As long as tab placement feature is present, we can open a separate request for that. Current implementation is trying to place it in the left most pane but not as the last tab of the pane. By the way, I don't see the pane placement working either, although I am using Atom 108 now. :)

jung-kim commented 10 years ago

Hmm that is not good.... I will look in to it