search

jung-kim / atom-ungit

Atom plugin for Ungit project
MIT License
75 stars 12 forks source link

Can't launch atom-ungit #15

Closed Akanoa closed 9 years ago

Akanoa commented 9 years ago

Hi, I've just installed atom-ungit, but when I launch it, I get this error: Uncaught TypeError: Cannot read property 'href' of null It's located at line 70 in file atom-ungit/lib/atom-ungit.coffee I hope, you would be able to fix it, Thanks.

jung-kim commented 9 years ago

Do you have an Window machine?

Akanoa commented 9 years ago

Yes it's exact, but I've tried to launch an ungit server installed by "npm install ungit -g" and it works...

jung-kim commented 9 years ago

Right, it's not ungit problem. It's a problem with atom-ungit. Atom-ungit isn't ready for windows machine as I don't have any machines to test with. I will do some work later today with possible fix and hopefully you can test it for me.

jung-kim commented 9 years ago

Latest master has possible solution and could you possibly pull it and test it before I publish another as I cannot test this?

If you need help on how to test this please let me know.

Akanoa commented 9 years ago

Your modification is good.

But, when you launch ungit, you use shebang #!/usr/bin/env node but this line doesn't have any sense on windows, you must specify which program you want to use.

In our case, you must launch node /path/to/ungit/module/ungit

jung-kim commented 9 years ago

Thanks for the pull and I have sent another release. Please let me know if that works.

Thanks!

Akanoa commented 9 years ago

It works, issue fixed :D