jung-kim / atom-ungit

Atom plugin for Ungit project
MIT License
75 stars 12 forks source link

Unnecessary horizontal scrollbar #40

Open ibnesayeed opened 8 years ago

ibnesayeed commented 8 years ago

There is an annoying horizontal scrollbar, although no content seem to be overflowing and the responsive layout seems to fit nicely withing the visible window. I was trying to play with the developer tool to change some iframe attribute and CSS styles but could not fix it. Is it only me or anyone else is experiencing it? I am using Ubuntu 15.04 and the latest version of Atom.

jung-kim commented 8 years ago

What version of Ungit are you running? and frankly there are some large presentation layer change coming soon so this may change.

ibnesayeed commented 8 years ago

I am using 0.9.3 which was installed as a dependency by the atom-ungit, not a stand alone installation.

By presentation layer changes, are you referring to the Electron based implementation of Ungit (which I don't see as a presentation layer change) or something else is being worked on that I am not aware of?

jung-kim commented 8 years ago

I was referring to https://github.com/FredrikNoren/ungit/pull/630. I will test it out later and fix x-width issue. which I'm betting iframe issue.

steelbrain commented 8 years ago

:+1:

jung-kim commented 8 years ago

With the latest ungit with FredrikNoren/ungit#630 of which that hasn't been released, either this problem is some what mitigated or not a problem any more.

Below is a screen shot that displays x-scroll bar showing up at a point and pictured nodes are the right most nodes I have in this particular repo. I could trim more fat on the svg dom to have more skinnier display but I'm not sure if I want to do that. When nodes with branch order of 3, right most nodes in the picture, have tag or remote it would be hard to work with.

screen shot 2015-11-23 at 5 05 33 pm