Closed ibnesayeed closed 10 years ago
I have asked for help in the Atom Discussion Board if there is a cleaner way in the API to get the context of the corresponding tab. Meanwhile I am applying a hack to get the context and modify the DOM to get the job done. Right now my hack is dependent on the title of the tab which in this case is "Ungit", it will have a side-effect that any tab with this exact title will have the same logo when the Ungit tab is opened. We can overcome this issue by making a very unique title, but I will wait for a cleaner way if there is one in the API.
Pull request #7 will take care of this.
We should add Ungit logo in the corresponding tab. This will allow us to remove the sticky header section in the Ungit iframe that contains the logo and the repository path. Keeping the logo in the tab will make it stand out for other tabs. Also, the repository path is not needed here because it is expected to open in the context of the editor itself. Refresh functionality can be bound to another keymap. And this way we will be able to shave off a very precious screen real-estate.
I will be making a request in the main Ungit repository to allow the client to request the Ungit server a page with or without the header. Then we can pass appropriate parameters in the URI to get the page without the header and if the directory context is not set in the editor (when the editor is opened from application menu for example) then we will open the iframe with the header in it.