Refactored Encode and Decode functions, Fixed Template ID Conflicts

jung-kurt / gofpdf

A PDF document generator with high level support for text, drawing and images

http://godoc.org/github.com/jung-kurt/gofpdf

MIT License

4.34k stars 787 forks source link

Refactored Encode and Decode functions, Fixed Template ID Conflicts #219

Closed d1ngd0 closed 5 years ago

d1ngd0 commented 5 years ago

Updated Encode and Decode to ensure templates and images are pointers to the original objects
Refactored so encoding no longer has to create p and o labels for images
removed id from template and generate it using Bytes instead.

jung-kurt commented 5 years ago

Nice work, @d1ngd0.

One thing we will need to be mindful of going forward is some kind of version check on independently stored templates. It's not inconceivable that breaking changes to the template structure will be made in the future. Given the short time frame templates have been saveable, it's not too big a worry now. Perhaps we should add a template format version number in the stored template so that when it is loaded back into gofpdf, the appropriate action can be taken.