Closed phpdave11 closed 5 years ago
@jung-kurt I've fixed the issues reported by make check
. I also installed pandoc and and ran make clean && make
but it looks like the generated README.md file and doc.go were already up to date.
Nice work, @phpdave11! Thanks for this very useful contribution!
@jung-kurt Thanks! I'm glad to help.
Thanks, @phpdave11! Could you make a few small changes?
First, README.md is a derived file; it is automatically generated from doc/document.md so doc.go and index.html can be kept in sync with the README file. You'll need a recent version of pandoc to generate the output. If you don't have this, no worries -- I can make the change.
Second, can you fix the problems reported by
make check
?I've done this already for the v2 branch. I really dislike that
golint
thinksId
should beID
but a clean report from golint tips the scale in favor of compliance. (See Capitalization of Initialisms.) I disregard the gocyclo complaints.