search

jung-kurt / gofpdf

A PDF document generator with high level support for text, drawing and images
http://godoc.org/github.com/jung-kurt/gofpdf
MIT License
4.29k stars 772 forks source link

Add SetUnderlineThickness method #293

Closed joewestcott closed 4 years ago

joewestcott commented 4 years ago

As described in #287

I've also included a test and added the result to pdf/reference, but it appears that folder is quite outdated compared to the current output of go test.

Is the reference folder meant to reflect the current output of go test? I can update it if so.

jung-kurt commented 4 years ago

Nice contribution, @joewestcott -- thanks!

The reference folder started out with good intentions but new ways kept popping up that caused PDFs to be generated differently in different environments. I finally disabled the check by default -- see the call to ComparePDFFiles in internal/example/example.go. I'm not sure whether anyone is using the reference directory in practice. It would be valuable to get a report on PDF discrepancies without causing tests to fail but I am not sure how this could be accomplished.