search

jung-kurt / gofpdf

A PDF document generator with high level support for text, drawing and images
http://godoc.org/github.com/jung-kurt/gofpdf
MIT License
4.33k stars 782 forks source link

Improve SVG support #295

Closed eiskasten closed 5 years ago

eiskasten commented 5 years ago

These commits, add support for horizontal lines, vertical lines and quadratic curves. In addition this pull request implemented the closepath support truly.

jung-kurt commented 5 years ago

Thanks, @Eiskasten!

Could you add an example, or augment ExampleFpdf_SVGBasicWrite, that demonstrates the new features? Alternatively, if you can provide an SVG file that includes the new instructions I can add an example.

In addition this pull request implemented the closepath support truly.

Oops! Good catch.

eiskasten commented 5 years ago

I provided an example now which also shows that the m instruction does not work correctly. At first I thought, that this was because after each z instruction the new coordinates were not set but that was not the case (I committed that nevertheless, just for the formal correctness).

jung-kurt commented 5 years ago

Super! Many thanks, @Eiskasten.