search

jung-kurt / gofpdf

A PDF document generator with high level support for text, drawing and images
http://godoc.org/github.com/jung-kurt/gofpdf
MIT License
4.33k stars 782 forks source link

why remove ImageOptionsReader() ? #322

Closed mitu217 closed 5 years ago

mitu217 commented 5 years ago

ImageOptionsReader is deleted by https://github.com/jung-kurt/gofpdf/commit/d17d13df9df41d4505501e831ff0ada5b2222ff8 immediately after being merged in https://github.com/jung-kurt/gofpdf/pull/281

I think that we want the ability to insert images retrieved as binary.

Please tell me why it was deleted?

jung-kurt commented 5 years ago

I think that we want the ability to insert images retrieved as binary.

This can be done; see this example.

Please tell me why it was deleted?

Image attributes were cached improperly.

mitu217 commented 5 years ago

@jung-kurt thank you immediately answer!

Sorry, I overlooked the sample. this issue will be closed 🙏