jung6717 / arduino

Automatically exported from code.google.com/p/arduino
0 stars 0 forks source link

Sample makefiles do not work if user PDE does not define new functions #198

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
The exemplar makefiles used in libraries/Firmata/examples/ServoFirmata/ do 
not correctly build the applet/$TARGET.cpp if the $TARGET.pde does not 
define functions other than void setup() and void loop().

Attached is a diff from SVN revision 868 which fixes the issue.

The sed line is pretty hairy, as it won't catch all prototypes, and could 
potentially catch code, and could generate errors. Maybe it should be 
removed and left up to the user to ensure the prototypes are properly 
visible in the .pde file?

Original issue reported on code.google.com by eoin.mcl...@gmail.com on 1 Feb 2010 at 10:34

Attachments:

GoogleCodeExporter commented 8 years ago
I'm not maintaining the Makefiles, so you should submit the patch to Firmata: 
http://firmata.org/

In any case, I probably won't include them in the next Arduino release.

Original comment by dmel...@gmail.com on 1 Feb 2010 at 10:44