jung6717 / arduino

Automatically exported from code.google.com/p/arduino
0 stars 0 forks source link

SVN keywords being used yet SVN keyword expansion not happening #277

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
There are places in the tree where SVN keywords are being used in files yet the 
SVN keyword expansion, which is controlled by the file properties, does not 
appear to have keyword expansion enabled.
For a specific example of file look at this file:
http://code.google.com/p/arduino/source/browse/trunk/hardware/arduino/cores/ardu
ino/wiring_digital.c

See line 22:

Here is some additional discussion on the topic:
http://www.arduino.cc/cgi-bin/yabb2/YaBB.pl?num=1277081988

Without the properties enabled, no keyword expansion will happen
and users get stale (wrong) information
in the SVN keywords - which is not good.

This is not isolated to the single file above.

Original issue reported on code.google.com by bperry...@gmail.com on 21 Jun 2010 at 6:34

GoogleCodeExporter commented 9 years ago
Is this relevant any more, now that Arduino is using git instead of svn?

Original comment by wes...@gmail.com on 13 Nov 2010 at 8:31

GoogleCodeExporter commented 9 years ago
Actually, yes I believe that this is still relevant. (but not in the same way)
While git chose not to implement any sort of keyword expansion, all the
old/out-of-date expanded keywords still exist in the arduino source code.
The real issue at this point is having the out of date keywords in the code.
So I believe that the answer at this point is to simply go remove the keywords
from all the arduino source code modules.

Original comment by bperry...@gmail.com on 13 Nov 2010 at 6:30

GoogleCodeExporter commented 9 years ago
Yes, this should be filed under "cleanup" for when those affected modules are 
updated.

Original comment by john.ve...@gmail.com on 1 Jul 2012 at 7:38

GoogleCodeExporter commented 9 years ago
https://github.com/arduino/Arduino/issues/277#issuecomment-118277578

Original comment by federico...@gmail.com on 3 Jul 2015 at 8:38