Switch to new api.porkbun.com hostname

jungaretti / bacon

Deploy your DNS records from YAML config files to Porkbun

GNU General Public License v3.0

12 stars 1 forks source link

Switch to new api.porkbun.com hostname #40

Closed susnick closed 4 weeks ago

susnick commented 1 month ago

Closes #39

jungaretti commented 1 month ago

Awesome! Thank you, this is the exact change I had in mind.

Something is wrong with the system tests on this branch. The automated run on main (with the same API key) succeeded: https://github.com/jungaretti/bacon/actions/runs/11301883950

I am on vacation this weekend. I can help debug and review this PR once I'm home next week.

jungaretti commented 1 month ago

GitHub intentionally limits access to repo secrets if the pull request comes from a forked repo.

https://docs.github.com/en/actions/security-for-github-actions/security-guides/using-secrets-in-github-actions#using-secrets-in-a-workflow
https://stackoverflow.com/questions/58737785/github-actions-empty-env-secrets

I didn't consider this when I added the system tests that require an API key as a PR check. I will open an issue to sort that out separately from this PR.