Closed GoogleCodeExporter closed 8 years ago
webrtc disables sysroot in this CL https://codereview.webrtc.org/1468313006
Set use_sysroot=0 until crbug.com/561584 is fixed
Original comment by fbarch...@chromium.org
on 15 Dec 2015 at 7:43
https://codereview.chromium.org/1526163002
Original comment by fbarch...@chromium.org
on 15 Dec 2015 at 8:06
The following revision refers to this bug:
https://chromium.googlesource.com/libyuv/libyuv.git/+/be984a8b9a130671c098920600ffb44cbb559340
commit be984a8b9a130671c098920600ffb44cbb559340
Author: Frank Barchard <fbarchard@google.com>
Date: Tue Dec 15 20:05:32 2015
Bump chromium version and disable use_sysroot=0
TBR=harryjin@google.com
BUG=libyuv:534
Review URL: https://codereview.chromium.org/1526163002 .
[modify] http://crrev.com/be984a8b9a130671c098920600ffb44cbb559340/DEPS
[modify] http://crrev.com/be984a8b9a130671c098920600ffb44cbb559340/libyuv.gyp
Original comment by bugdroid1@chromium.org
on 15 Dec 2015 at 8:06
unclear if fixed... re-occurred. Appears to be sensitive to depot tools and/or
being on same drive as source.
Original comment by fbarch...@chromium.org
on 16 Dec 2015 at 5:25
webrtc runhooks fails with
________ running 'c:\src\depot_tools\python276_bin\python.exe
src/webrtc/build/gyp_webrtc -Dextra_gyp_flag=0' in 'c:\src\webrtc'
Updating projects from gyp files...
Traceback (most recent call last):
File "src/webrtc/build/gyp_webrtc", line 115, in <module>
File "c:\src\webrtc\src\tools\gyp\pylib\gyp\__init__.py", line 538, in main
return gyp_main(args)
File "c:\src\webrtc\src\tools\gyp\pylib\gyp\__init__.py", line 523, in gyp_main
generator.GenerateOutput(flat_list, targets, data, params)
File "c:\src\webrtc\src\tools\gyp\pylib\gyp\generator\ninja.py", line 2403, in GenerateOutput
pool.map(CallGenerateOutputForConfig, arglists)
File "c:\src\depot_tools\python276_bin\lib\multiprocessing\pool.py", line 250, in map
return self.map_async(func, iterable, chunksize).get()
File "c:\src\depot_tools\python276_bin\lib\multiprocessing\pool.py", line 554, in get
raise self._value
Exception:
"['c:\\src\\depot_tools\\win_toolchain\\vs2013_files\\win_sdk\\Bin\\SetEnv.Cmd',
'/x86', '&&', 'set']" failed with error 1
Original comment by fbarch...@chromium.org
on 16 Dec 2015 at 8:09
The following revision refers to this bug:
https://chromium.googlesource.com/libyuv/libyuv.git/+/40fd801a28f3020277fb435c36f94a4bba1f9171
commit 40fd801a28f3020277fb435c36f94a4bba1f9171
Author: Frank Barchard <fbarchard@google.com>
Date: Wed Dec 16 23:52:14 2015
roll to same version of chromium as head webrtc
BUG=libyuv:534
R=kjellander@chromium.org
Review URL: https://codereview.chromium.org/1535493002 .
[modify] http://crrev.com/40fd801a28f3020277fb435c36f94a4bba1f9171/DEPS
Original comment by bugdroid1@chromium.org
on 16 Dec 2015 at 11:53
Original comment by fbarch...@chromium.org
on 17 Dec 2015 at 12:16
The issue here is not that the sysroot is missing any headers, its that the
builder in question doesn't seem to have the sysroot installed. This is
normally setup by gclient hooks in chromium. If you don't want to use the
sysroot in your build of chromium maybe we can set use_sysroot in the
GYP_DEFINES, but setting in libyuv.gyp ends up effecting the chromium build..
in particular it has broken the Linux ARM FYI builder:
https://build.chromium.org/p/chromium.fyi/builders/Linux%20ARM
Original comment by sbc@chromium.org
on 6 Jan 2016 at 6:43
Re-opening issue.
I'm locally having 2 issues.
1. gcc 32 bit linux doesnt build. but clang does
2. android gclient runhooks fails.
Both started mid december and may be an interaction with depottools.
I needed to roll forward to new chromium deps for benefit of Windows builds and
was pulling in changes done in webrtc when they did DEPS rolls.
Original comment by fbarch...@google.com
on 7 Jan 2016 at 1:25
Re #9: Should this really be reopened? Please file new issues for those instead
if this one is resolved.
I made a CL for adding a GCC bot to the libyuv waterfall + tryserver:
https://codereview.chromium.org/1573853002/ but we shouldn't add that until you
say GCC is fixed.
The Android runhooks error is covered in bug 536
Original comment by kjellan...@google.com
on 10 Jan 2016 at 8:03
The following revision refers to this bug:
https://chromium.googlesource.com/libyuv/libyuv.git/+/0e462e6f450b9248a83feee50871e1ad76d317c3
commit 0e462e6f450b9248a83feee50871e1ad76d317c3
Author: Frank Barchard <fbarchard@google.com>
Date: Mon Jan 11 22:57:50 2016
Remove use_sysroot=0
use_sysroot=0 is required for webrtc on linux intel builds, but
libyuv doesnt use the affected libraries, so removing this.
R=harryjin@google.com, sbc@chromium.org
BUG=libyuv:534,libyuv:542
Review URL: https://codereview.chromium.org/1566303002 .
[modify] http://crrev.com/0e462e6f450b9248a83feee50871e1ad76d317c3/libyuv.gyp
[modify]
http://crrev.com/0e462e6f450b9248a83feee50871e1ad76d317c3/source/scale_win.cc
[modify]
http://crrev.com/0e462e6f450b9248a83feee50871e1ad76d317c3/unit_test/convert_test
.cc
Original comment by bugdroid1@chromium.org
on 11 Jan 2016 at 10:58
I think we should close this bug.
Original comment by kjellan...@google.com
on 12 Jan 2016 at 6:16
Original comment by fbarch...@google.com
on 16 Jan 2016 at 2:13
Original issue reported on code.google.com by
fbarch...@google.com
on 15 Dec 2015 at 6:43