jungshadow / yfpp

A foul-mouthed election information application.
https://yourfuckingpollingplace.com
1 stars 1 forks source link

fix electionSelect #143

Open JesseSilverberg opened 3 years ago

JesseSilverberg commented 3 years ago

Currently the electionSelect is blank. The reason for this is that it only displays relevantElections, as defined in Search.js. The logic there to parse the state from the query wasn't correctly parsing my input string (see screenshot).

Screen Shot 2021-06-07 at 7 18 27 PM

My solution was to offload the parsing to Google, since they return a parsed address in some of their responses. I tried grabbing normalizedAddress from AppContext, but that would only work if I messed with the search bar again once I was on the results page. What I ended up doing is separating the calls to representatives and voterinfo, feeding the parsed address from representatives into the relevantElections logic and then pass the calculated election ID to the voterinfo call. I suppose this is a slight performance hit; if there is another place to get the parsed address that I missed, that might be better (maybe Mapbox?).