jungshadow / yfpp

A foul-mouthed election information application.
https://yourfuckingpollingplace.com
1 stars 1 forks source link

ElectionSelect "Softlocking" #144

Open JesseSilverberg opened 3 years ago

JesseSilverberg commented 3 years ago

This bug arises from the fact that the electionSelect is only shown on certain tabs, and tabs are hidden if they have no data (see #85).

Expected behavior

Not actually sure, there's a few ways I could see this going. I suppose one solution would be to move the electionSelect higher up in the hierarchy, either in the menu on the left or to display above the tabbed/paginated content (like the search bar does).

Actual behavior

You get stuck on the representatives page.

Steps to reproduce the behavior

Enter "700 Avalon Avenue, Virginia Beach, Virginia 23464, United States". There are 2 elections for this address: the Virginia Democratic Primary and the Virginia Republican Primary. Note that screenshots are from my local environment running #143. If you use electionSelect to pick the Republican Primary, the "Polling Place" and "Drop Off Sites" tabs disappear. Maybe this is intended (lmao), but I could see this being a bigger issue if, for example, the election picked by default were the one missing the tabs.

Screen Shot 2021-06-07 at 7 34 03 PM Screen Shot 2021-06-07 at 7 34 11 PM