search

jungsoft / materialui-daterange-picker

A react date range picker implementation using @material-ui.
MIT License
70 stars 79 forks source link

Also export DateRangePicker without Popper and ClickAwayListener #3

Closed ffMathy closed 4 years ago

ffMathy commented 4 years ago

This allows someone to automatically decide how the component should be shown.

@jungrafael let me know if there are any changes you want to have made.

pedro-lb commented 4 years ago

Hey there @ffMathy !

Thanks for your contribution! 🚀

I'm afraid I can't merge this as it is - since we've changed the default export. This would result in a breaking change that would affect all current applications that use this dependency.

We still need to export DateRangePickerExporter as DateRangePicker, to keep compatibility. But we can certainly add another export for DateRangePicker (maybe call it DateRangePickerComponent?).

image

We'll merge as soon as these changes have been added.

ffMathy commented 4 years ago

Hey @pedro-lb I made the changes as requested.

ffMathy commented 4 years ago

@pedro-lb any ETA on when this can be merged and published to NPM?

Thanks in advance, and thank you for reviewing my PR so detailed.

pedro-lb commented 4 years ago

Thanks @ffMathy !

I'll publish a new version shortly

pedro-lb commented 4 years ago

Released - https://github.com/jungsoft/materialui-daterange-picker/releases/tag/1.1.92