search

junhaoliao / iCtrl

A Simple VNC + SSH Shell + SFTP Client
https://ictrl.ca
Other
168 stars 14 forks source link

add: add the new prompt when connection failed #21

Closed Leo6Leo closed 1 year ago

junhaoliao commented 1 year ago

The issue can be caused by:

  1. iCtrl mistakenly thought Port 5900 is open due to a bug in mac port checking mechanism: [VNC] fix a bug in macOS check port 5900 open method
  2. False firewall alarm due to iCtrl listening on all interfaces (0.0.0.0), which has been addressed in 7218310207c88937873e7c82ea16712882d09e7c and e8529f0eac3bb14a741a8d6df776921d09cf4001 .

Given the issue has been properly addressed, should we abandon this review?

Leo6Leo commented 1 year ago

The issue can be caused by:

  1. iCtrl mistakenly thought Port 5900 is open due to a bug in mac port checking mechanism: [VNC] fix a bug in macOS check port 5900 open method
  2. False firewall alarm due to iCtrl listening on all interfaces (0.0.0.0), which has been addressed in 7218310 and e8529f0 .

Given the issue has been properly addressed, should we abandon this review?

Got it. Glad the issue is resolved from the root! I will close this Pull Request.